-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Run tests on Windows & macOS in CI #4970
Conversation
… fail Will probably time out or being cancelled
…t killed between steps
…he pubsub download step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks for the macOS file - overall this looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good from my perspective, I imagine the cache using the same as the build script should be ok - @Nerixyz is is double-checking before this is merged in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
$HOST/status/{code}
endpoints, so I searched for alternatives and found httpbox, which I then used.Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
.--output-on-failure
to the workflow to see where the problem is if a test fails. Initially done to find a problem during playing around with it, but I think I can be helpful for later, so I kept it.Occasional Problem
Subprocess aborted
at different cases but I don't know why that might be. For me, it was always fixed after re-running the workflow.Thought
To not have to use Docker and Colima on macOS, I could build the pubsub server and the httpbox tool on macOS in background too I think, but that probably won't make a difference I think.
Closes #4780