Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: common/Credentials #4979

Merged
merged 12 commits into from
Nov 26, 2023
Merged

refactor: common/Credentials #4979

merged 12 commits into from
Nov 26, 2023

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Nov 26, 2023 •
edited
Loading

Description

  • Include full path
  • Sort includes
  • Move anon namespace out of chatterino namespace
  • Use auto * where possible
  • disable convert-member-function-to-static check
  • no else after return
  • Remove empty constructor
  • Use std::variant instead of boost::variant

Nerixyz
Nerixyz reviewed Nov 26, 2023
View reviewed changes
src/common/Credentials.cpp Outdated Show resolved Hide resolved
@pajlada pajlada force-pushed the chore/refactor-common-credentials branch from 6364ee2 to 290817f Compare November 26, 2023 12:54
@pajlada pajlada enabled auto-merge (squash) November 26, 2023 18:24
@pajlada pajlada merged commit 1f09035 into master Nov 26, 2023
19 checks passed
@pajlada pajlada deleted the chore/refactor-common-credentials branch November 26, 2023 18:38
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nerixyz Nerixyz Nerixyz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pajlada @Nerixyz