Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Twitch PubSub client #5059

Merged
merged 13 commits into from
Jan 6, 2024
Merged

refactor: Twitch PubSub client #5059

merged 13 commits into from
Jan 6, 2024

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Dec 31, 2023

  • Remove unused setAccountData function
  • Move PubSub out of TwitchIrcServer and into Application
  • Add changelog entry

github-actions[bot]
github-actions bot reviewed Dec 31, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

mocks/include/mocks/EmptyApplication.hpp Outdated Show resolved Hide resolved
src/Application.cpp Show resolved Hide resolved
src/Application.cpp Show resolved Hide resolved
src/Application.cpp Show resolved Hide resolved
@Nerixyz Nerixyz mentioned this pull request Dec 31, 2023
Closed
Nerixyz
Nerixyz reviewed Dec 31, 2023
View reviewed changes
mocks/include/mocks/EmptyApplication.hpp Outdated Show resolved Hide resolved
src/providers/twitch/PubSubManager.cpp Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Dec 31, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

mocks/include/mocks/EmptyApplication.hpp Show resolved Hide resolved
mocks/include/mocks/EmptyApplication.hpp Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Dec 31, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

tests/src/TwitchPubSubClient.cpp Show resolved Hide resolved
@pajlada
quit pubsub on exit
3e77f2f 
might conflict with exit removal, so can be reverted but this shows it's possible
github-actions[bot]
github-actions bot reviewed Dec 31, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/providers/twitch/PubSubClient.cpp Show resolved Hide resolved
src/providers/twitch/PubSubManager.cpp Show resolved Hide resolved
@pajlada pajlada marked this pull request as ready for review January 2, 2024 23:03
github-actions[bot]
github-actions bot reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/providers/twitch/PubSubManager.cpp Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Jan 6, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/providers/twitch/PubSubManager.cpp Show resolved Hide resolved
src/providers/twitch/PubSubManager.cpp Show resolved Hide resolved
@pajlada pajlada merged commit 416806b into master Jan 6, 2024
20 checks passed
@pajlada pajlada deleted the chore/refactor-twitch-pubsub branch January 6, 2024 12:18
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Nerixyz Nerixyz Nerixyz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pajlada @Nerixyz