Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Streamlink documentation #5076

Merged
merged 14 commits into from
Jan 12, 2024

Conversation

fraxxio
Copy link
Contributor

@fraxxio fraxxio commented Jan 10, 2024

Solving #5073
Added new QLabel in ExternalToolsPage.cpp.

Note

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/widgets/settingspages/ExternalToolsPage.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't apply to Linux and I don't think it applies to Mac either. Should probably be if-defed to Windows only.

src/widgets/settingspages/ExternalToolsPage.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/widgets/settingspages/ExternalToolsPage.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/widgets/settingspages/ExternalToolsPage.cpp Outdated Show resolved Hide resolved
@pajlada pajlada changed the title Adding note to ExternalToolsPage.cpp Improve Streamlink documentation Jan 12, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/util/StreamLink.cpp Show resolved Hide resolved
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, would like approval from the previous reviewers before merging this in

I took the opportunity to do some minor refactors at the same time, thank you for your contribution!

@Mm2PL Mm2PL requested a review from Nerixyz January 12, 2024 20:04
@Felanbird Felanbird merged commit 06f950a into Chatterino:master Jan 12, 2024
20 checks passed
@fraxxio fraxxio deleted the add-note-for-streamlink branch January 12, 2024 20:18
devJimmyboy pushed a commit to devJimmyboy/chatterino7 that referenced this pull request Feb 11, 2024
Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants