Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Streamlink documentation #5076

Merged
merged 14 commits into from
Jan 12, 2024
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
- Minor: The whisper highlight color can now be configured through the settings. (#5053)
- Minor: Added missing periods at various moderator messages and commands. (#5061)
- Minor: Improved color selection and display. (#5057)
- Minor: Add a note in `Extarnal Tools` page, `Streamlink`. (#5076)
- Bugfix: Fixed an issue where certain emojis did not send to Twitch chat correctly. (#4840)
- Bugfix: Fixed capitalized channel names in log inclusion list not being logged. (#4848)
- Bugfix: Trimmed custom streamlink paths on all platforms making sure you don't accidentally add spaces at the beginning or end of its path. (#4834)
Expand Down
17 changes: 17 additions & 0 deletions src/widgets/settingspages/ExternalToolsPage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,15 @@
#define STREAMLINK_QUALITY \
"Choose", "Source", "High", "Medium", "Low", "Audio only"

constexpr QStringView getBinaryName()
{
#ifdef Q_OS_WIN
return u"streamlink.exe";
#else
return u"streamlink";
#endif
}

namespace chatterino {

ExternalToolsPage::ExternalToolsPage()
Expand Down Expand Up @@ -60,6 +69,14 @@ ExternalToolsPage::ExternalToolsPage()
getSettings()->streamlinkUseCustomPath);
groupLayout->setWidget(2, QFormLayout::SpanningRole, customPathCb);

auto note = new QLabel(
fraxxio marked this conversation as resolved.
Show resolved Hide resolved
QStringLiteral(
"Chatterino expects the executable to be called \"%1\".")
.arg(getBinaryName()));
note->setWordWrap(true);
note->setStyleSheet("color: #bbb");
groupLayout->setWidget(3, QFormLayout::SpanningRole, note);

auto customPath = this->createLineEdit(getSettings()->streamlinkPath);
customPath->setPlaceholderText(
"Path to folder where Streamlink executable can be found");
Expand Down
Loading