Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make ChatterinoBadges less of a singleton #5103

Merged
merged 7 commits into from
Jan 19, 2024

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Jan 18, 2024

  • refactor: Make ChatterinoBadges a non-singleton
  • Add some mini comments
  • remove unused include
  • rename variables to remove _
  • use named initializers

The request for badges now happen as the class is constructed. I made the class "mockable" to ensure this request doesn't take place in tests.

@pajlada pajlada force-pushed the refactor/chatterino-badges branch from f7d4a3e to 08a30fe Compare January 19, 2024 12:11
@pajlada pajlada marked this pull request as draft January 19, 2024 14:22
@pajlada pajlada marked this pull request as ready for review January 19, 2024 15:55
@pajlada pajlada merged commit 326a402 into master Jan 19, 2024
21 checks passed
@pajlada pajlada deleted the refactor/chatterino-badges branch January 19, 2024 16:25
devJimmyboy pushed a commit to devJimmyboy/chatterino7 that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant