refactor: Remove most raw accesses into Application #5104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
force-pushed
the
refactor/use-getiapp-more
branch
from
ede151b to
e898ac0
Compare
With this change, we no longer assert that getSeventvBadges is only called in the GUI thread.
and add a getter for it
pajlada
force-pushed
the
refactor/use-getiapp-more
branch
from
e898ac0 to
7dc3852
Compare
1 task
devJimmyboy
pushed a commit
to devJimmyboy/chatterino7
that referenced
this pull request
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost everything now uses their getXXX() function, meaning we always check/assert if required by the getter
The one real change this PR does is remove the assert from the
getSeventvBadges()functionThis PR will be force-pushed after #5103 has been merged in