fix(channel-view): use underlyingChannel_ over channel_
#5248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
changed the title
underlyingChannel_ over channel_
Felanbird
approved these changes
Mar 12, 2024
pajlada
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting a channel in a
ChannelViewthat has messages, these are copied into the internal message buffer, but aren't added to the backing channel used for search. With this PR, the messages are both added to the backing buffer and to the channel. This also fixes a bug where filters weren't taken into account (non-issue here, as there aren't any set by default).Seems like this broke in #1748.
Fixes #3861.
To help future patches, I commented all channels a view holds onto. It's a bit confusing to have three channels and one always needs to check what they are. In the past, we've made mistakes of using the wrong channel. For example, I missed this in #5123 and even #1748 missed this when handling
layoutRequested.