Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update color of usernames & boldness of usernames on the fly #5300

Merged
merged 6 commits into from
May 12, 2024

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Apr 6, 2024

Boldness was already covered before

Fixes #2637

@pajlada pajlada added this to the Post-2.5.0 milestone Apr 6, 2024
@pajlada pajlada force-pushed the fix/update-colored-usernames-on-the-fly branch from 7cf5bbc to 4066468 Compare April 7, 2024 09:24
@Mm2PL Mm2PL self-requested a review April 15, 2024 00:21
@pajlada
Copy link
Member Author

pajlada commented May 12, 2024

This should be ready for a review now @Mm2PL if you want to take a peek

To test, mention a user in a normal & a /me message, then flick the Bold @usernames and Color @usernames settings on and off

Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected on Twitch and IRC

Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A mistake was made: I can't copy username text

Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(misclick)

pajlada added 2 commits May 12, 2024 14:10
This ensures it's included in other text-like things, and not excluded
@Mm2PL Mm2PL self-requested a review May 12, 2024 12:12
Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything including copying messages works now. LGTM

@pajlada pajlada enabled auto-merge (squash) May 12, 2024 12:20
@pajlada pajlada merged commit 3d5acff into master May 12, 2024
17 checks passed
@pajlada pajlada deleted the fix/update-colored-usernames-on-the-fly branch May 12, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling Color @username does not disable already colored usernames, unlike Bold @username
2 participants