Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check state when completing commands #5401

Merged
merged 4 commits into from
Jun 19, 2024
Merged

fix: check state when completing commands #5401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00b8d22
fix: check state when completing commmands
Nerixyz May 17, 2024
5de57ff
chore: add changelog entry
Nerixyz May 17, 2024
8cc6345
Merge branch 'master' into fix/bad-meta-plugin
Mm2PL May 22, 2024
ab3b920
Merge branch 'master' into fix/bad-meta-plugin
Mm2PL Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
- Bugfix: Fixed restricted users usernames not being clickable. (#5405)
- Bugfix: Fixed a crash that could occur when logging was enabled in IRC servers that were removed. (#5419)
- Bugfix: Fixed message history occasionally not loading after a sleep. (#5457)
- Bugfix: Fixed a crash when tab completing while having an invalid plugin loaded. (#5401)
- Dev: Update Windows build from Qt 6.5.0 to Qt 6.7.1. (#5420)
- Dev: Update vcpkg build Qt from 6.5.0 to 6.7.0, boost from 1.83.0 to 1.85.0, openssl from 3.1.3 to 3.3.0. (#5422)
- Dev: Unsingletonize `ISoundController`. (#5462)
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/plugins/PluginController.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ std::pair<bool, QStringList> PluginController::updateCustomCompletions(

for (const auto &[name, pl] : this->plugins())
{
if (!pl->error().isNull())
if (!pl->error().isNull() || pl->state_ == nullptr)
{
continue;
}
Expand Down
Loading