-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more firefox variants for incognito link opening #5503
Conversation
teknsl
commented
Jul 10, 2024
- firefox-devedition
- firefox-beta
- firefox-nightly
- qutebrowser
* firefox-devedition * firefox-beta * firefox-nightly * qutebrowser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love for us to find browsers either by URL associations or XDG desktop files. XDG desktop files usually have a new-private-window
action. We wouldn't need to explicitly add support for every single web browser on the planet. However that might not be worth the complexity.
That said I'm completely ok accepting this patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add firefox-developer-edition
to the list. And a changelog entry
(I may have misclicked approve before)
src/util/IncognitoBrowser.cpp
Outdated
{"firefox-devedition", "-private-window"}, | ||
{"firefox-beta", "-private-window"}, | ||
{"firefox-nightly", "-private-window"}, | ||
{"qutebrowser", "--target", "private-window"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This opens a new window, not sure if there is a better version that opens a tab in an existing private window, might be worth noting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
firefoxes open in an existing window for me but could not find anything to make qutebrowser open in an existing window
i did not try to build and missed the type however i only added qutebrowser while i was already adding browsers, i do not daily drive this so i will remove it maybe pr should be renamed to reduce scope? |
It's okay to remove qutebrowser. It seems that the private window switch isn't all that good in it anyway. |
Thank you for your contribution. As a first-time contributor, you can now add yourself to the contributors list that's shown inside the About page in Chatterino. If you want this, you can open a new PR where you modify the |