Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more firefox variants for incognito link opening #5503

Merged
merged 5 commits into from
Jul 11, 2024
Merged

Support more firefox variants for incognito link opening #5503

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cdcc03a
private browsing support for more browsers
teknsl Jul 10, 2024
8e9f88c
only one argument can be provided
teknsl Jul 11, 2024
70b792f
firefox developer edition on arch linux
teknsl Jul 11, 2024
3e6262d
add to changelog
teknsl Jul 11, 2024
8585cd4
Update CHANGELOG.md
Mm2PL Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Minor: Added `/warn <username> <reason>` command for mods. This prevents the user from chatting until they acknowledge the warning. (#5474)
- Minor: Improve appearance of reply button. (#5491)
- Minor: Introduce HTTP API for plugins. (#5383, #5492, #5494)
- Minor: Support more firefox variants for incognito link opening
Mm2PL marked this conversation as resolved.
Show resolved Hide resolved
- Bugfix: Fixed tab move animation occasionally failing to start after closing a tab. (#5426)
- Bugfix: If a network request errors with 200 OK, Qt's error code is now reported instead of the HTTP status. (#5378)
- Bugfix: Fixed restricted users usernames not being clickable. (#5405)
Expand Down
4 changes: 4 additions & 0 deletions src/util/IncognitoBrowser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ QString getPrivateSwitch(const QString &browserExecutable)
{"firefox-esr", "-private-window"},
{"chromium", "-incognito"},
{"brave", "-incognito"},
{"firefox-devedition", "-private-window"},
teknsl marked this conversation as resolved.
Show resolved Hide resolved
{"firefox-developer-edition", "-private-window"},
{"firefox-beta", "-private-window"},
{"firefox-nightly", "-private-window"},
};

// compare case-insensitively
Expand Down
Loading