Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct selection index when double-clicking into the void #5617

Merged
merged 2 commits into from
Oct 2, 2024
Merged

fix: use correct selection index when double-clicking into the void #5617

merged 2 commits into from
Oct 2, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Oct 2, 2024

From pajlada:

  • Double click emote/emoji to select it
  • Double click outside a message (in the void) and drag
  • Expected: The selection starts at the nearest element - Previous: The selection starts at that selected emote/emoji

Technically, this fix does some duplicate work, since we did the work of looking at all elements, but shouldn't be that bad.

pajlada
pajlada approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@pajlada pajlada merged commit 4d9ea37 into Chatterino:master Oct 2, 2024
18 checks passed
@Nerixyz Nerixyz deleted the fix/selection-again branch November 3, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nerixyz @pajlada