From fa2dfe92bef6c142c0f9c74497a1af0c9225625e Mon Sep 17 00:00:00 2001 From: Johannes Date: Wed, 2 Oct 2024 17:11:23 +0200 Subject: [PATCH 1/2] fix: use correct selection index when double-clicking into the void --- src/widgets/helper/ChannelView.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/widgets/helper/ChannelView.cpp b/src/widgets/helper/ChannelView.cpp index 026af4c1061..93be6ad91ba 100644 --- a/src/widgets/helper/ChannelView.cpp +++ b/src/widgets/helper/ChannelView.cpp @@ -2707,6 +2707,10 @@ void ChannelView::mouseDoubleClickEvent(QMouseEvent *event) if (hoverLayoutElement == nullptr) { + // XXX: this is duplicate work + auto idx = layout->getSelectionIndex(relativePos); + SelectionItem item(messageIndex, idx); + this->doubleClickSelection_ = {item, item}; return; } From 90599a18c92c18e1bdb4c66868b47186c365750b Mon Sep 17 00:00:00 2001 From: Johannes Date: Wed, 2 Oct 2024 17:21:23 +0200 Subject: [PATCH 2/2] chore: add changelog entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0755efc9d88..ba3c188b96a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -51,6 +51,7 @@ - Bugfix: Fixed log files being locked longer than needed. (#5592) - Bugfix: Fixed global badges not showing in anonymous mode. (#5599) - Bugfix: Fixed grammar in the user highlight page. (#5602) +- Bugfix: Fixed double-click selection not working when clicking outside a message. (#5617) - Dev: Update Windows build from Qt 6.5.0 to Qt 6.7.1. (#5420) - Dev: Update vcpkg build Qt from 6.5.0 to 6.7.0, boost from 1.83.0 to 1.85.0, openssl from 3.1.3 to 3.3.0. (#5422) - Dev: Unsingletonize `ISoundController`. (#5462)