Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clarify Lua submodule version #5693

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

brian6932
Copy link
Contributor

@brian6932 brian6932 commented Nov 4, 2024

Updating submodules causes

lib\sol2\include\sol/compatibility/compat-5.3.h(404): fatal error C1189: #error: "unsupported Lua version (i.e. not Lua 5.1, 5.2, 5.3, or 5.4)"

@Felanbird Felanbird requested a review from Mm2PL November 4, 2024 05:40
@Nerixyz
Copy link
Contributor

Nerixyz commented Nov 4, 2024

lua master uses 505

That shouldn't matter. We're checked out on the v5.4.7 tag. If we'd use the latest master commit, Sol would break in CI.

@brian6932
Copy link
Contributor Author

We're checked out on the v5.4.7 tag

Yes, but it's not exactly clear that updating submodules will break the build. Imo the branch should just be specified in .gitmodules, especially since lua releases are set to their own branches anyway.

@pajlada
Copy link
Member

pajlada commented Nov 4, 2024

This is less of a fix, and more of a hint to future developers clarifying what branch we're tracking.
It also makes it easier for us to be able to track changes to that specific branch, since Lua maintains old versions as branches

@pajlada pajlada changed the title fix: sol using unsupported lua version chore: clarify Lua submodule version Nov 4, 2024
@pajlada pajlada merged commit 03cdd98 into Chatterino:master Nov 4, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants