chore: use condition variable to shutdown websocket pools #5721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
force-pushed
the
chore/eradicate-std-async
branch
from
8b36069 to
c995c97
Compare
pajlada
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to spawn a new thread to wait on another thread to shut down. We can use a condition variable to synchronize the threads. (Conceptually), the exiting thread sets the variable and the parent waits on that event.
I abstracted that into a
OnceFlag(better names are welcome). It's a flag that can be set and waited on. The tests involve some timing measurements because we want to wait for some time and "not wait for some time" when the flag is already set.