Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML-588 ⁃ #272 Add Skip action when the content is unrenderable #594

Merged
merged 1 commit into from
Jan 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/components/ActivityScreens.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ class ActivityScreens extends React.PureComponent {
currentScreen,
onChange,
authToken,
onContentError,
} = this.props;
const { activeScreens, direction } = this.state;
return (
Expand All @@ -60,6 +61,7 @@ class ActivityScreens extends React.PureComponent {
onChange={onChange}
authToken={authToken}
isCurrent={index === currentScreen}
onContentError={onContentError}
/>
</SlideInView>
))}
Expand All @@ -74,6 +76,7 @@ ActivityScreens.propTypes = {
currentScreen: PropTypes.number.isRequired,
authToken: PropTypes.string.isRequired,
onChange: PropTypes.func.isRequired,
onContentError: PropTypes.func.isRequired,
};

export default ActivityScreens;
5 changes: 4 additions & 1 deletion app/components/screen/Widget.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import {
} from '../../widgets';
import TimePicker from '../../widgets/TimeRange/TimePicker';

const Widget = ({ screen, answer, onChange, isCurrent, onPress, onRelease }) => {
const Widget = ({ screen, answer, onChange, isCurrent, onPress, onRelease, onContentError }) => {
if (screen.inputType === 'radio'
&& R.path(['valueConstraints', 'multipleChoice'], screen) === true) {
return (
Expand Down Expand Up @@ -194,6 +194,8 @@ const Widget = ({ screen, answer, onChange, isCurrent, onPress, onRelease }) =>
if (screen.inputType === 'markdown-message') {
return null;
}

onContentError();
return <WidgetError />;
};

Expand All @@ -207,6 +209,7 @@ Widget.propTypes = {
screen: PropTypes.object.isRequired,
answer: PropTypes.any,
onChange: PropTypes.func.isRequired,
onContentError: PropTypes.func.isRequired,
isCurrent: PropTypes.bool.isRequired,
onPress: PropTypes.func,
onRelease: PropTypes.func,
Expand Down
4 changes: 3 additions & 1 deletion app/components/screen/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ class ActivityScreen extends Component {
}

render() {
const { screen, answer, onChange, isCurrent } = this.props;
const { screen, answer, onChange, isCurrent, onContentError } = this.props;
const { scrollEnabled, inputDelayed, timerActive } = this.state;
return (
<View style={styles.outer}>
Expand Down Expand Up @@ -174,6 +174,7 @@ class ActivityScreen extends Component {
screen={screen}
onPress={() => { this.setState({ scrollEnabled: false }); }}
onRelease={() => { this.setState({ scrollEnabled: true }); }}
onContentError={onContentError}
/>
)
}
Expand All @@ -196,6 +197,7 @@ ActivityScreen.propTypes = {
screen: PropTypes.object.isRequired,
answer: PropTypes.any,
onChange: PropTypes.func.isRequired,
onContentError: PropTypes.func.isRequired,
isCurrent: PropTypes.bool.isRequired,
};

Expand Down
20 changes: 16 additions & 4 deletions app/scenes/Activity/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import React, { useState } from 'react';
import { StatusBar, View, StyleSheet } from 'react-native';
import { Container } from 'native-base';
import PropTypes from 'prop-types';
Expand Down Expand Up @@ -55,6 +55,8 @@ const Activity = ({
const fullScreen = currentItem.fullScreen || activity.fullScreen;
const autoAdvance = currentItem.autoAdvance || activity.autoAdvance;

const [isContentError, setContentError] = useState(false);

return (
<Container>
<StatusBar hidden />
Expand All @@ -69,16 +71,26 @@ const Activity = ({
}
}}
authToken={authToken}
onContentError={() => setContentError(true)}
/>
{!fullScreen && (
<View style={styles.buttonArea}>
{activity.items.length > 1 && (
<ActProgress index={currentScreen} length={activity.items.length} />
)}
<ActivityButtons
nextLabel={getNextLabel(currentScreen, itemVisibility, activity, responses)}
nextEnabled={isNextEnabled(currentScreen, activity, responses)}
onPressNext={nextScreen}
nextLabel={getNextLabel(
currentScreen,
itemVisibility,
activity,
responses,
isContentError,
)}
nextEnabled={isNextEnabled(currentScreen, activity, responses, isContentError)}
onPressNext={() => {
setContentError(false);
nextScreen();
}}
prevLabel={getPrevLabel(currentScreen, itemVisibility)}
prevEnabled={isPrevEnabled(currentScreen, activity)}
onPressPrev={prevScreen}
Expand Down
8 changes: 4 additions & 4 deletions app/services/activityNavigation.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ export const getLastPos = (index, ar) => {
return -1;
};

export const getNextLabel = (index, visibility, activity, responses) => {
export const getNextLabel = (index, visibility, activity, responses, isContentError) => {
// If the screen is not valid, then the label is Skip
const isValid = checkValidity(activity.items[index], responses[index]);
if (!isValid) {
if (!isValid || isContentError) {
return SKIP;
}

Expand All @@ -60,10 +60,10 @@ export const getNextLabel = (index, visibility, activity, responses) => {
};

// If item has a valid response, or is skippable, then next is enabled
export const isNextEnabled = (index, activity, responses) => {
export const isNextEnabled = (index, activity, responses, isContentError) => {
const isValid = checkValidity(activity.items[index], responses[index]);
const isSkippable = checkSkippable(activity, activity.items[index]);
return isValid || isSkippable;
return isValid || isSkippable || isContentError;
};

export const isPrevEnabled = (index, activity) => {
Expand Down