Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use @include or @skip when stitching #7149

Closed
gondera opened this issue Jun 5, 2024 · 1 comment
Closed

Unable to use @include or @skip when stitching #7149

gondera opened this issue Jun 5, 2024 · 1 comment

Comments

@gondera
Copy link

gondera commented Jun 5, 2024

Product

Hot Chocolate

Version

13.5.1

Link to minimal reproduction

#937

Steps to reproduce

  1. Create a stitched schema
  2. Attempt to use an @include directive with a boolean field in playground. For example:
query TEST($ok:Boolean!) {
  hey {
    hello @include(if:$ok)
  }
}
  1. The field is executed when $ok is false

What is expected?

Same behavior as if the literal true or false were passed to the @include directive.
Just like if we query the original schema, the field is not queried if false.

What is actually happening?

After some debuging I noticed that the $ok variable didn't reach the original schema and that the query was simplified and doesn't contain the @include directive.

This looks like a issue parsing the query.

Same situation happened in previous versions like described in issue #937

Relevant log output

No response

Additional context

No response

@michaelstaib
Copy link
Member

Stitching is deprecated in favor of HotChocolate.Fusion. We are no longer offering any fixes or updates for stitching. With version 14 we have removed the code and packages for stitching.

HotChocolate.Fusion on the other hand supports skip/include and also subscriptions out of the box.

@michaelstaib michaelstaib reopened this Jun 5, 2024
@michaelstaib michaelstaib closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
@michaelstaib michaelstaib reopened this Jun 5, 2024
@michaelstaib michaelstaib closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
@ChilliCream ChilliCream locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants