Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce non-generic type descriptor method descriptor.Type(System.Type). #1079

Closed
michaelstaib opened this issue Sep 17, 2019 · 4 comments
Closed
Assignees
Milestone

Comments

@michaelstaib
Copy link
Member

michaelstaib commented Sep 17, 2019

#1058

For dynamic schema creating it would be useful to have a new Type description method that can be used to dynamically set types.

We need to write some validation logic that ensures the type context is always correct (input vs output).

Places where we have a type context:

  • Object Fields
  • Object Field Arguments
  • Interface Fields
  • Interface Field Arguments
  • Input Fields
  • Directive Arguments
@promontis
Copy link
Contributor

@michaelstaib I've created a PR for this enhancement. Is it ok like this?

@michaelstaib
Copy link
Member Author

I will have a look at it later or in the morning.

@promontis
Copy link
Contributor

@michaelstaib did you already manage to have a look? :)

@michaelstaib
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants