Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Relay node field did not show in SDL #1175

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Fixed: Relay node field did not show in SDL #1175

merged 2 commits into from
Oct 29, 2019

Conversation

michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented Oct 29, 2019 •
edited
Loading

The node field was marked as introspection field. This meant that the schema printer would skip that field.

Moreover, the field had a return type of Node! which was not following the spec where it is described as nullable.

https://relay.dev/graphql/objectidentification.htm

type Query {
  node(id: ID!): Node
}

Fixes #1026

@michaelstaib michaelstaib changed the base branch from master to version_10_0_0_master October 29, 2019 13:23
@michaelstaib michaelstaib self-assigned this Oct 29, 2019
@michaelstaib michaelstaib added this to the 10.2.0 milestone Oct 29, 2019
@michaelstaib michaelstaib merged commit 94cc778 into version_10_0_0_master Oct 29, 2019
@michaelstaib michaelstaib deleted the relay_node_field branch October 29, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelstaib michaelstaib

Labels
None yet
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@michaelstaib