Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't initialize the signer in solido unless we need to #426

Open
ruuda opened this issue Sep 13, 2021 · 0 comments
Open

Don't initialize the signer in solido unless we need to #426

ruuda opened this issue Sep 13, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@ruuda
Copy link
Contributor

ruuda commented Sep 13, 2021

Currently we always initialize the signer, even if we are not going to sign anything. Especially when using a Ledger this can be confusing, because it confirms the signer address, so you get Ledger activity even for read-only operations.

Aside from that, it should be possible to run the read-only commands without having a key at all.

Maybe we can add the signer to the client lazily?

@ruuda ruuda added the enhancement New feature or request label Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant