Fix parsing of multisig errors #360
Conversation
| ErrorCode::InvalidThreshold, | ||
| ]; | ||
|
|
||
| // The purpose of the match statement below is to trigger a compile error if |
There was a problem hiding this comment.
This is the match below the below match, right?
There was a problem hiding this comment.
It’s about the match statement directly below the comment, on line 289. As you can see, it does absolutely nothing at all, all of the match arms are empty. The reason it’s here, is to trigger the compiler’s exhaustiveness check. Suppose the multisig program adds ErrorCode::CanOnlyApproveOnTuesdays in a future version, and we did not have this match. Then we might miss the addition, and forget to add it to the all_errors list above. Then an CanOnlyApproveOnTuesdays error occurs, and our code would claim it’s not a known multisig error. Therefore I added the match here. If a new version of the multisig program adds a variant, then that will cause a compile error here, saying that the case ErrorCode::CanOnlyApproveOnTuesdays is not covered. When a programmer then goes on to add the case, they will hopefully notice the comment (or else a reviewer should), and add the new case to the all_errors list above as well.
This is broken in Anchor, but we can do it by hand then ...
#177 was starting to bug me, “fix” it. This is a bit of an ugly fix; the bug is in Anchor and it really should be fixed there (this turned out to be the problem), but until then, we can work around it here.