Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Workspace #100

Open
ChristopherPHolder opened this issue Oct 2, 2024 · 1 comment
Open

Restructure Workspace #100

ChristopherPHolder opened this issue Oct 2, 2024 · 1 comment

Comments

@ChristopherPHolder
Copy link
Owner

TL;DR;

Restructure workspace to improve architecture and readability.

Description

Currently the workspace is very badly structures, and has no documentation about the way things should be structures.

This MR will improve the general structure to reflect best practices. It will also add proper documentation into the readme and lint rules to prevent this issue from coming back.

References:

@ChristopherPHolder
Copy link
Owner Author

ChristopherPHolder commented Oct 2, 2024

Generally speaking there are top level approaches to folder structures:

  • apps/libs
  • packages/tools

There is no right and wrong answer here but I agree with Edouard Bozon.

Using packages/tools will be used to provide better code colocation.

This is already partially implemented to the repo already. But is not properly implmented as currently many things are provided in the top level packages. This make it very hard to read and not easy to understand what is and project of its own and what actually belongs to another project.

For this reason we will reserve the top level to applications or packages and shared

packages
├──  api
├──  portal
├──  runner
└──  shared
runner
├──  e2e
├──  app-cli
├──  data-access-queue
├──  data-access-store
├──  feature-replay
├──  util-interfaces
└──  util-middleware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant