Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when marlin source not found properly #2

Open
jbellmore opened this issue Nov 8, 2020 · 2 comments
Open

Add warning when marlin source not found properly #2

jbellmore opened this issue Nov 8, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@jbellmore
Copy link

Hello!

First, great idea for a project really dig it! When I went to create a config from the default marlin for my printer at first I kept getting an empty set of settings in the yml file. I realized I was being thick and when specifying the marlin folder i was specifying the root folder of the cloned marlin repo NOT the Marlin subfolder that contains the actual firmware. Once I added that subfolder it created the config fine.

So I would just suggest to add a feature that gives a warning if it does not find the firmware rather than spitting out an empty config. Might help some people, particularly if they are unfamiliar with Docker and its volume mounts and don't end up mounting the volumes correctly.

Great job, looking forward to see how this project progresses!

@Chuckame
Copy link
Owner

Chuckame commented Nov 8, 2020

Hello @jbellmore, and thank-you for your feedback. I'm glad that my project is interesting you!!

Yes, I like this idea. I will complete this feature with :

  • warn when no file found
  • display which files are found
  • add/update examples to have not only one volume, but maybe 2 volumes: one for profiles, and the other for Marlin.

What do you think?

Also, if you have any idea to improve the documentation & examples, don't hesitate to ask me.

@jbellmore
Copy link
Author

Hey, sorry for the delay.

Yeah that sounds great! Would definitely help I think.

As for the volume mounts yes I totally agree. I have used a fair amount of docker images and that pattern seems to have become more standard. Having one mount for something like app/Marlin and one mount for app/Config would give people more flexibility in their file structure. In my particular case I want to store the configs in one git repo and have marlin cloned elsewhere. This way I can run the tool from within the path where I have my config repo cloned if that makes sense.

Thanks, appreciate the work!

@Chuckame Chuckame added the enhancement New feature or request label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants