You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First, great idea for a project really dig it! When I went to create a config from the default marlin for my printer at first I kept getting an empty set of settings in the yml file. I realized I was being thick and when specifying the marlin folder i was specifying the root folder of the cloned marlin repo NOT the Marlin subfolder that contains the actual firmware. Once I added that subfolder it created the config fine.
So I would just suggest to add a feature that gives a warning if it does not find the firmware rather than spitting out an empty config. Might help some people, particularly if they are unfamiliar with Docker and its volume mounts and don't end up mounting the volumes correctly.
Great job, looking forward to see how this project progresses!
The text was updated successfully, but these errors were encountered:
Yeah that sounds great! Would definitely help I think.
As for the volume mounts yes I totally agree. I have used a fair amount of docker images and that pattern seems to have become more standard. Having one mount for something like app/Marlin and one mount for app/Config would give people more flexibility in their file structure. In my particular case I want to store the configs in one git repo and have marlin cloned elsewhere. This way I can run the tool from within the path where I have my config repo cloned if that makes sense.
Hello!
First, great idea for a project really dig it! When I went to create a config from the default marlin for my printer at first I kept getting an empty set of settings in the yml file. I realized I was being thick and when specifying the marlin folder i was specifying the root folder of the cloned marlin repo NOT the Marlin subfolder that contains the actual firmware. Once I added that subfolder it created the config fine.
So I would just suggest to add a feature that gives a warning if it does not find the firmware rather than spitting out an empty config. Might help some people, particularly if they are unfamiliar with Docker and its volume mounts and don't end up mounting the volumes correctly.
Great job, looking forward to see how this project progresses!
The text was updated successfully, but these errors were encountered: