Checkout parameter of publish job is not used.

[eddiewebb]

Orb version:

12.0.3

What happened:

While supporting client and looking at means to inject custom logic I noticed the publish job will optinoally attach workspace and then publish, but unlike review/pack jobs never runs checkout, regardless of parameter (step does not exist)

Expected behavior:

Remove parameter or use it in a conditional checkout step.

Additional Information:

[kelvintaywl]

the checkout (bool) parameter is part of the publish job indeed:

orb-tools-orb/src/jobs/publish.yml

Lines 78 to 82 in 7b7c291

	checkout:
	type: boolean
	default: true
	description: |
	If you do not wish to checkout the source code, you may disable this behavior. Replace the checkout and add your own command or steps via the 'pre-steps' parameter in your workflow.

however, there is no actual conditional step to checkout based on this parameter (i.e., the parameter is not used)

[KyleTryon]

Thanks folks, ill take a look at this shortly.

[jtatarik]

This issue is still present in 12.0.4. Have to work around it by adding explicit checkout pre-step.