Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Speed limits overlay - show marker to indicate underground segments? #1325

Open
originalfoo opened this issue Jan 27, 2022 · 8 comments
Assignees
Labels
enhancement Improve existing feature Overlays Overlays, data vis, etc. SPEED LIMITS Feature: Speed limits Usability Make mod easier to use
Milestone

Comments

@originalfoo
Copy link
Member

From #1322 (comment) :

Train Tracks works too but for underground it requires switching with PageDown to show signs. They probably forget about that, maybe add tiny sign or v so notify that something is there or another toggle to always show everything
image

@originalfoo originalfoo added enhancement Improve existing feature Usability Make mod easier to use SPEED LIMITS Feature: Speed limits Overlays Overlays, data vis, etc. labels Jan 27, 2022
@kvakvs
Copy link
Collaborator

kvakvs commented Jan 27, 2022

There is code to show underground segments with arrow down. We just don't draw them but should you render them, the arrows will be visible once again.

@originalfoo
Copy link
Member Author

            if (segment.IsBothEndsUnderground()) {
                render.DrawSmallTexture_TopLeft(RoadUI.Instance.Underground);
            }

@originalfoo originalfoo added this to the 11.6.5 milestone Jan 27, 2022
@originalfoo originalfoo self-assigned this Jan 27, 2022
@originalfoo
Copy link
Member Author

Underground segments are currently excluded from the cache when not in underground camera mode - see: ShowSigns_RefreshVisibleSegmentsCache()

Rather than excluding them from the cache, we could add a bool isUnderground_ to struct CachedSegment.

I'm already updating the overlays code to pass a CachedSegment (rather than it's two properties split out) to the rendering methods, so that isUnderground_ will be available and actionable during rendering (this also means we don't need to recheck for underground again in the render methods).

Overground segments will still be excluded from cache when camera is in underground mode.

@originalfoo
Copy link
Member Author

Just leaving this here for future reference :)

Singleton<TransportManager>.instance.TunnelsVisible = true;

@originalfoo
Copy link
Member Author

image

@originalfoo
Copy link
Member Author

image

@originalfoo
Copy link
Member Author

originalfoo commented Jan 28, 2022

Could potentially show down arrow icon and when hovered still allow speed set (maybe even show the current speed limit icon on hover)?

image
image

Or have it so clicking the down arrow switches to undeground view?

@kvakvs
Copy link
Collaborator

kvakvs commented Jan 28, 2022

Could potentially show down arrow icon and when hovered still allow speed set (maybe even show the current speed limit icon on hover)?
Or have it so clicking the down arrow switches to undeground view?

We already have tools for switching underground view, its Pg Up, and Pg Down. Making more interactable markers is not useful for locations where more than 2 roads overlap (tunnel + bridge + some ground road), we tried to declutter screen and hide signs, instead of adding more signs. If you want to display some info in the underground markers, at least don't make them interactable

@originalfoo originalfoo modified the milestones: 11.6.5.0, 11.6.5.1 Feb 15, 2022
@originalfoo originalfoo modified the milestones: 11.6.5.1, 11.6.5.2 Feb 23, 2022
@krzychu124 krzychu124 modified the milestones: 11.7.1, Planned stuff Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing feature Overlays Overlays, data vis, etc. SPEED LIMITS Feature: Speed limits Usability Make mod easier to use
Projects
None yet
Development

No branches or pull requests

3 participants