Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lane Connection tool does not give UI feedback when lane is connected. #1485

Closed
Tracked by #1479
kianzarrin opened this issue Mar 22, 2022 · 10 comments · Fixed by #1491
Closed
Tracked by #1479

Lane Connection tool does not give UI feedback when lane is connected. #1485

kianzarrin opened this issue Mar 22, 2022 · 10 comments · Fixed by #1491
Assignees
Labels
Annoyance Not a bug, but just as annoying LANE ROUTING Feature: Lane arrows / connectors UI User interface updates

Comments

@kianzarrin
Copy link
Collaborator

kianzarrin commented Mar 22, 2022

When I making a new lane connection, the bezier snaps to lane. When I click there is no visual difference in the bezier. I wouldn't know if connection was successfully made unless if I move the mouse away which is annoying.

image
making a connection does thicken the line a little bit if you know where to look. but as you can see from picture above its too subtle.

Possible solutions:

  • don't snap to lanes
  • create a dashed line when removing connection
  • change mouse cursor to +/x when adding/removing connections respectively
  • the line thickness could be visibly different.
  • differentiate by using filled or hallow lane connection overlay.
  • EDIT: differentiate by using white color Future lane connector pimping #670
  • EDIT: reduce opacity of the floating lane beizer
  • a combination of above
@kianzarrin kianzarrin added Annoyance Not a bug, but just as annoying triage Awaiting issue categorisation UI User interface updates LANE ROUTING Feature: Lane arrows / connectors labels Mar 22, 2022
@originalfoo
Copy link
Member

I think a combination will work best - there's different contexts of situational awareness.

the line thickness could be visibly different.

Dragged line could be thinner so when a connector is added, the user sees line getting fatter. Likewise, when connector removed, the line would get thinner.

don't snap to lanes

I'd wait to see whether line thickness tweak works first, as I suspect its effectiveness of that will be dependent on lane snapping.

differentiate by using filled or hollow lane connection overlay.

Yes! This will be particularly helpful on large/complex junctions with herds of lane connections; it will make it much easier to see at a glance which outgoing lanes are connected to currently selected incoming lane.

change mouse cursor to +/x when adding/removing connections respectively

Yes, definitely! Although I'd use - rather than x. To me x means 'delete' which seems ambiguous in situations where there's multiple connections to a given lane. Using - subtract is a bit more specific and also visually more simple.

Maybe something like this for "add" (and a red - for "subtract"):
image

Is there some way to extract the pngs of the existing cursors used by the game? That would help with constructing new cursors.

@kianzarrin
Copy link
Collaborator Author

@aubergine10 Its going to be hard to have the bezier overlay to be both thin and hollow because if it is thin then there is not much area left inside. we need to consider the borders have some thickness too (maybe I should think out the borders but I am not sure if it is possible).

Yes! This will be particularly helpful on large/complex junctions with herds of lane connections; it will make it much easier to see at a glance which outgoing lanes are connected to currently selected incoming lane.

how?

@kianzarrin
Copy link
Collaborator Author

kianzarrin commented Mar 22, 2022

Is this issue a duplicate of #670?

@kianzarrin
Copy link
Collaborator Author

kianzarrin commented Mar 22, 2022

Before (#635 (review))
before

Now:
nottop
where did that white sheath go? it is no longer visible when the floating lane bezeir snaps to lane.
@krzychu124 Is this regression?

@kianzarrin
Copy link
Collaborator Author

kianzarrin commented Mar 23, 2022

@aubergine10 I think we can do this:

  • make floating line white and hollow so that we can see if there is a connection underneath.
  • mouse cursor also shows if we are adding/removing a connection.

@chameleon-tbn
Copy link
Contributor

to be consistent we would at least a general TMPE cursor and the + / - one. otherwise it will look strange if suddenly within TMPE the cursorstyle changes... and if we start this various more custom TMPE cursors might be needed.

imho also it would be needed to add generally code for custom cursor to TMPE... or is this already build in somewhere? @aubergine10

@krzychu124
Copy link
Member

@chameleon-tbn could you prepare few cursor textures to solve the problem? I'll add a bit of code to support it.

@kianzarrin kianzarrin self-assigned this Mar 25, 2022
@originalfoo
Copy link
Member

@chameleon-tbn For cursor design I was thinking it would be good to base our cursors of the default game cursor to give users a familiar feel. (The example image I posted earlier was just grabbed off internet as a vague illustration of how +/- might be added on to the game cursor)

@kianzarrin
Copy link
Collaborator Author

test icon
image

@chameleon-tbn
Copy link
Contributor

@aubergine10 i did with Arrow Pointer, but imho w/o Looks better
cursor_add_lane_connector_256
cursor_remove_lane_connector_256
cursor_add_lane_connector_-_256
cursor_remove_lane_connector_-_256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Annoyance Not a bug, but just as annoying LANE ROUTING Feature: Lane arrows / connectors UI User interface updates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants