Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove second check on row count to stop extract failing on frequently updated large tables #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jrmidkiff
Copy link
Collaborator

cco.asset_history may be updated as frequently as every 1-3 minutes around an election, and it uses dbtools postgres extract method to extract the data to S3.

geopetl extract can take 20-40 seconds to extract the table to CSV, by which point a later Jenkins script run on cco.asset_history may have already run and changed the table count. The second check was comparing the CSV row count to the current table row count, which by now may be already outdated.

We already have a 1st check to compare the CSV row count to the table row count at the time of the extraction, so this 2nd check in my opinion adds no value and merely adds the potential for useless exceptions.

If merging to main, please git tag as v1.3.7 and publish a new release, or let me do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants