Remove second check on row count to stop extract failing on frequently updated large tables #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cco.asset_history
may be updated as frequently as every 1-3 minutes around an election, and it uses dbtools postgres extract method to extract the data to S3.geopetl extract can take 20-40 seconds to extract the table to CSV, by which point a later Jenkins script run on
cco.asset_history
may have already run and changed the table count. The second check was comparing the CSV row count to the current table row count, which by now may be already outdated.We already have a 1st check to compare the CSV row count to the table row count at the time of the extraction, so this 2nd check in my opinion adds no value and merely adds the potential for useless exceptions.
If merging to main, please git tag as
v1.3.7
and publish a new release, or let me do it