Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports #653

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix imports #653

merged 1 commit into from
Dec 17, 2024

Conversation

ori-opher
Copy link
Member

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@matanvax2 matanvax2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the best approach at this point (which is by far the most consistent with other notebooks) is to replace with -

from classiq import *

In the (hopefully near) future I expect open-library functions to be distributed as a separate, and not imported directly from classiq.

@ori-opher ori-opher force-pushed the fix-open-lib-functions branch 2 times, most recently from ff9fb0e to 611d9d0 Compare December 17, 2024 09:47
@ori-opher ori-opher removed the request for review from orsa-classiq December 17, 2024 09:48
@ori-opher ori-opher force-pushed the fix-open-lib-functions branch from 611d9d0 to 5859724 Compare December 17, 2024 10:17
@ori-opher ori-opher merged commit 1dcabf7 into dev Dec 17, 2024
2 checks passed
Copy link

💪 Well done @ori-opher! Two PRs merged already! 🎉🥳

With your second PR, you're on a roll, and your contributions are already making a difference. 🌟
Looking forward to seeing even more contributions from you. Keep up the great work! 🚀

@classiqdor classiqdor deleted the fix-open-lib-functions branch January 23, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants