Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add h3 misc functions - part 2 #33621

Merged
merged 29 commits into from
Jan 22, 2022
Merged

Conversation

bharatnc
Copy link
Contributor

@bharatnc bharatnc commented Jan 14, 2022

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add new h3 miscellaneous functions: edgeLengthKm,exactEdgeLengthKm,exactEdgeLengthM,exactEdgeLengthRads,numHexagons.

Detailed description / Documentation draft:

Add new h3 miscellaneous functions: edgeLengthKm,exactEdgeLengthKm,exactEdgeLengthM,exactEdgeLengthRads,numHexagons.
as per: https://h3geo.org/docs/api/misc/

Splitting up adding the functions into smaller PRs so that it's easy to review.

Related to: #17708

@robot-clickhouse robot-clickhouse added doc-alert pr-feature Pull request with new product feature labels Jan 14, 2022
@kitaisreal kitaisreal self-assigned this Jan 14, 2022
@bharatnc bharatnc marked this pull request as ready for review January 14, 2022 20:40
@bharatnc
Copy link
Contributor Author

Failing tests don't seem to be related.

Copy link
Collaborator

@kitaisreal kitaisreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make small fixes. Then ready to merge.

src/Functions/h3EdgeLengthM.cpp Outdated Show resolved Hide resolved
src/Functions/h3HexAreaM2.cpp Outdated Show resolved Hide resolved
src/Functions/h3HexAreaKm2.cpp Outdated Show resolved Hide resolved
@bharatnc
Copy link
Contributor Author

Fixed build issues, looks like fmtlib doesn't allow mixing int types while formatting the exception.

2022-01-21 17:32:46 In file included from ../src/Functions/h3HexAreaKm2.cpp:5:
2022-01-21 17:32:46 In file included from ../src/Columns/ColumnsNumber.h:4:
2022-01-21 17:32:46 In file included from ../src/Columns/ColumnVector.h:4:
2022-01-21 17:32:46 In file included from ../src/Columns/IColumn.h:5:
2022-01-21 17:32:46 In file included from ../src/Common/Exception.h:12:
2022-01-21 17:32:46 In file included from ../contrib/fmtlib-cmake/../fmtlib/include/fmt/format.h:44:
2022-01-21 17:32:46 /build/contrib/fmtlib/include/fmt/core.h:996:5: error: static_assert failed due to requirement 'std::is_same<char8_t, char>::value || std::is_same<char8_t, char>::value' "mixing character types is disallowed"
2022-01-21 17:32:46     static_assert(
2022-01-21 17:32:46     ^
2022-01-21 17:32:46 /build/contrib/fmtlib/include/fmt/core.h:1273:32: note: in instantiation of function template specialization 'fmt::detail::arg_mapper<fmt::basic_format_context<fmt::detail::buffer_appender<char>, char>>::map<char8_t, 0>' requested here
2022-01-21 17:32:46   return arg_mapper<Context>().map(val);
...                   ^

@kitaisreal kitaisreal merged commit 4100512 into ClickHouse:master Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants