Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Materialized column batch insert #1209

Closed
iyuroch opened this issue Feb 29, 2024 · 4 comments
Closed

Materialized column batch insert #1209

iyuroch opened this issue Feb 29, 2024 · 4 comments

Comments

@iyuroch
Copy link
Contributor

iyuroch commented Feb 29, 2024

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

When doing batch insert into the table without specifying column names driver deduces columns from described table and does not take into account materialized columns

Describe the solution you'd like
Ignore materialized columns during batch column generation.

Describe alternatives you've considered
Specifying separate columns, however this approach works bad for us since type of materialized column is not support by clickhouse-go

@iyuroch
Copy link
Contributor Author

iyuroch commented Feb 29, 2024

It can be tackled during "describe table" batch init flow by filtering out all materialized columns so we do not init them, the change should be relatively small.

@jkaflik
Copy link
Contributor

jkaflik commented Feb 29, 2024

@iyuroch thanks for submitting. Would you like to submit a PR?

@iyuroch
Copy link
Contributor Author

iyuroch commented Feb 29, 2024

@jkaflik sure

@iyuroch
Copy link
Contributor Author

iyuroch commented Mar 1, 2024

#1214

@iyuroch iyuroch closed this as completed Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants