add trilogy support #79
Closed
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seuros would you mind taking a look at this? With Rails 7.1 out, there's going to be an increase in demand for using Trilogy |
joevandyk
commented
Oct 25, 2023
| @@ -1 +1 @@ | |||
| ruby 3.0.5 | |||
| ruby 3.2.1 | |||
There was a problem hiding this comment.
(i can revert this if needed)
|
Did you check my open pr ? Seem trilogy is failling in some test. I will take a look again |
joevandyk
commented
Oct 26, 2023
joevandyk
commented
Oct 26, 2023
joevandyk
commented
Oct 26, 2023
joevandyk
commented
Oct 26, 2023
joevandyk
commented
Oct 26, 2023
Ah, I didn't see that one! I'll check it out |
|
Thank you for your PR. Already supported in latest version, including legacy versions. Let me know if you face any error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds suport for the trilogy mysql-compatible adapter
fixes #78
we've been using this change in production for a couple weeks, no issues noted.