Remove providers setup from module and enhacement docs. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feliperfmarques
changed the title
feliperfmarques
force-pushed
the
remove-providers-setup
branch
from
dcce7b8 to
b208293
Compare
…r logging and monitoring module. Adding correct serviceAccount config for sysdig agent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First I would like to thank you for this module.
However, I needed to use this in a use case where the logging a monitoring instances were in a different resource group than cluster, so I needed to make these changes and I am going up this PR.
I had first submitted PR #1 and PR #2, but after submitting PR 2, I thought better and I believe that just removing the providers setup from this module solves the problem for related use case, since the kubernetes provider is configured in the root module. Besides that, I believe that in most cases it is not so common to have different resource groups for logging and monitoring instances, so this configuration is not necessary. For this reason, I closed the last two PRs and I'm only submitting this one.
In addition, I added
provision_activity_trackermodule variable for README docs.