Skip to content

Commit

Permalink
Fixes subtle bug in zio_handle_io_delay()
Browse files Browse the repository at this point in the history
Fixed bug introduced in commit #c35b1882.  Hinted by gcc:

zio_inject.c: In function ‘zio_handle_io_delay’:
zio_inject.c:382:3: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
   if (handler->zi_record.zi_freq != 0 &&
      ^~
      zio_inject.c:384:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
          continue;
	      ^~~~~~~~

Signed-off-by: Marcel Huber <marcelhuberfoo@gmail.com>
Signed-off-by: Chunwei Chen <tuxoko@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#4632
  • Loading branch information
marcelhuberfoo authored and ryao committed Jun 7, 2016
1 parent e4ec31e commit 0bc1298
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion module/zfs/zio_inject.c
Original file line number Diff line number Diff line change
Expand Up @@ -380,8 +380,9 @@ zio_handle_io_delay(zio_t *zio)
continue;

if (handler->zi_record.zi_freq != 0 &&
spa_get_random(100) >= handler->zi_record.zi_freq);
spa_get_random(100) >= handler->zi_record.zi_freq) {
continue;
}

if (vd->vdev_guid == handler->zi_record.zi_guid) {
seconds = handler->zi_record.zi_timer;
Expand Down

0 comments on commit 0bc1298

Please sign in to comment.