Skip to content
This repository has been archived by the owner on May 18, 2019. It is now read-only.

Cocoapods Core version in Gemfile #52

Closed
k0nserv opened this issue Aug 11, 2014 · 10 comments · Fixed by #53
Closed

Cocoapods Core version in Gemfile #52

k0nserv opened this issue Aug 11, 2014 · 10 comments · Fixed by #53

Comments

@k0nserv
Copy link
Member

k0nserv commented Aug 11, 2014

Currently the Cocoapods Core version is not specifying the branch directly for the Core repository. Instead it's using the version available on RubyGems. Among other things this prevents overriding the gem with a local path. Is there are reason for it or should it be changed to use the same format as https://github.com/CocoaPods?

@k0nserv
Copy link
Member Author

k0nserv commented Aug 16, 2014

@floere what do you think. I want to expose deprecation status as part of the returned data, but this requires new code from the Core. I tried running against Core master branch, but that seems to break a lot of the tests, I could of course fix these as a part of point the Core to the master branch too

@orta
Copy link
Member

orta commented Aug 16, 2014

@k0nserv - I think this makes sense, we'll need those Core changes around the others system too. So I'd make the change to master. @floere is away on holiday, so feel free to ping me or @alloy ( we don't know too much about search but can offer good advice probably ) if you have problems 👍

@k0nserv
Copy link
Member Author

k0nserv commented Aug 16, 2014

@orta Okay I will update it to use the master branch for the Core and go through the failing tests and adjust them according to the changes in the core

@k0nserv
Copy link
Member Author

k0nserv commented Aug 17, 2014

The specs in tests broke when updating to 0.33.0 from my testing so far this is the diff between 0.33.0 and the previous version which was 0.32.1. At row 39 in spec/api/flat_ids_integration_spec.rb the test fails because it no longer returns the pods MapBox. @orta do you have anymore insight of what happened between 0.32.1 and 0.33.0 before I review the changes manually. I suspect that the following line(Gracefully handle unexpected source structure.)(CocoaPods/Core#110) in the Changelog might be related

@orta
Copy link
Member

orta commented Aug 17, 2014

Well, MapBox got deprecated, think that might be the reason?

@k0nserv
Copy link
Member Author

k0nserv commented Aug 17, 2014

Not sure, when it runs the test it uses the data folder for the as the source to my understanding. Doing a grep -R deprecated spec/data does not return anything related to MapBox so unless I am missing something I don't think that should affect it

@k0nserv
Copy link
Member Author

k0nserv commented Aug 17, 2014

This commit is what caused it to break CocoaPods/Core@15a071e

@k0nserv
Copy link
Member Author

k0nserv commented Aug 17, 2014

It is indeed used by the MapBox pod as seen here. So should I remove that whole pod from the data folder then?

@k0nserv k0nserv mentioned this issue Aug 17, 2014
@orta
Copy link
Member

orta commented Aug 17, 2014

Yes! That makes sense to me.

@k0nserv
Copy link
Member Author

k0nserv commented Aug 17, 2014

Okay I did just that in #53 preparing the actual deprecation status PR right now by adding a few deprecated pods to the spec pods

@orta orta closed this as completed in #53 Aug 17, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants