Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync last 2 weeks changes #48

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

art049
Copy link
Member

@art049 art049 commented Jul 12, 2024

This pull request was created automatically by CodSpeed to track performance changes of the pull request cloudflare/pingora#322.

The original branch is upstream/bleeper-yuchen-940539c7d0bff45d8182d4eb6c40d099b20ed44e

When we see a GOAWAY(NO_ERROR), the connector no longer fail the entire request.
Now the connector creates a new connection instead.
Although it is implied that fail_to_connect() errors are already caused
by upstream connections, it is more clear for the user's code inside this callback
by marking the error source in this case.
The display format contains more useful info.
Copy link

codspeed-hq bot commented Jul 12, 2024

CodSpeed Performance Report

Merging #48 will not alter performance

Comparing upstream/bleeper-yuchen-940539c7d0bff45d8182d4eb6c40d099b20ed44e (c493194) with main (e4f3696)

Summary

✅ 2 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants