From 73b1ea2649727dfc1a02aae960640d7272830d80 Mon Sep 17 00:00:00 2001
From: Ben Lerner <blerner@ccs.neu.edu>
Date: Fri, 24 Sep 2021 16:54:48 -0400
Subject: [PATCH] initial attempts at a more visual select-menu to choose users
 to impersonate.  will likely be useful as a standalone component, and used in
 other parts of the UI

---
 app/javascript/components/common/helpers.ts   |  6 +--
 .../components/workflows/home/index.tsx       | 52 ++++++++++++-------
 .../workflows/professor/courses/show.tsx      | 13 ++---
 3 files changed, 40 insertions(+), 31 deletions(-)

diff --git a/app/javascript/components/common/helpers.ts b/app/javascript/components/common/helpers.ts
index fd876de86..396166028 100644
--- a/app/javascript/components/common/helpers.ts
+++ b/app/javascript/components/common/helpers.ts
@@ -55,12 +55,12 @@ export function pluralize(number: number, singular: string, plural: string): str
   return `${number} ${plural}`;
 }
 
-export type SelectOption<T> = {
+export type SelectOption<T, Extra = unknown> = {
   label: string;
   value: T;
-};
+} & Extra;
 
-export type SelectOptions<T> = SelectOption<T>[];
+export type SelectOptions<T, Extra = unknown> = SelectOption<T, Extra>[];
 
 export type MutationReturn<T extends MutationParameters> = [
   MutateWithVariables<T>, MutationState<T>
diff --git a/app/javascript/components/workflows/home/index.tsx b/app/javascript/components/workflows/home/index.tsx
index 66c53c0bd..d75d17b64 100644
--- a/app/javascript/components/workflows/home/index.tsx
+++ b/app/javascript/components/workflows/home/index.tsx
@@ -8,7 +8,7 @@ import {
   useMutation,
 } from 'relay-hooks';
 import { RenderError } from '@hourglass/common/boundary';
-import Select, { GroupedOptionsType } from 'react-select';
+import Select, { GroupedOptionsType, OptionProps, components } from 'react-select';
 import {
   Button,
   Container,
@@ -278,17 +278,43 @@ const ShowProfRegs: React.FC<{
   );
 };
 
-export type ImpersonateVal = SelectOption<string>
+export type ImpersonateVal = SelectOption<string, {imageUrl?: string}>
+
+const ImpersonateUserOption: React.FC<OptionProps<ImpersonateVal>> = (props) => {
+  const {
+    data,
+  } = props;
+  const value = data as ImpersonateVal;
+  return (
+    <div className="d-inline-block" style={{ maxWidth: '200px', verticalAlign: 'top' }}>
+      {(
+        // eslint-disable-next-line react/jsx-props-no-spreading
+        <components.Option {...props} className="d-inline-block p-2 rounded-lg">
+          <Card style={{ color: 'black' }}>
+            <Card.Header className="p-0" style={{ height: '200px', overflow: 'clip' }}>
+              {value.imageUrl ? (
+                <Card.Img className="profile-photo" src={value.imageUrl} alt={value.label} />
+              ) : (
+                <Icon I={MdPerson} size="100%" />
+              )}
+            </Card.Header>
+            <Card.Body>
+              {value.label}
+            </Card.Body>
+          </Card>
+        </components.Option>
+      )}
+    </div>
+  );
+};
 
 export const ImpersonateUser: React.FC<{
   userOptions: ImpersonateVal[] | GroupedOptionsType<ImpersonateVal>;
-  userIdToImageMap: { [key: string]: string; };
   courseId?: ImpersonateUserInput['courseId'];
 }> = (props) => {
   const {
     userOptions,
     courseId,
-    userIdToImageMap,
   } = props;
   const { alert } = useContext(AlertContext);
   const [impersonate, { loading }] = useMutation(
@@ -322,8 +348,9 @@ export const ImpersonateUser: React.FC<{
             placeholder="Select a user to impersonate..."
             isDisabled={loading}
             options={userOptions}
+            components={{ Option: ImpersonateUserOption }}
             formatOptionLabel={(option) => {
-              const userHasImage = option.value in userIdToImageMap;
+              const userHasImage = !!option.imageUrl;
               return (
                 <OverlayTrigger
                   placement="right"
@@ -335,7 +362,7 @@ export const ImpersonateUser: React.FC<{
                       {...overlayProps}
                     >
                       {userHasImage ? (
-                        <img className="profile-photo" src={userIdToImageMap[option.value]} alt={option.label} />
+                        <img className="profile-photo" src={option.imageUrl} alt={option.label} />
                       ) : (
                         <span>No image for that user.</span>
                       )}
@@ -343,11 +370,6 @@ export const ImpersonateUser: React.FC<{
                   )}
                 >
                   <span>
-                    {userHasImage ? (
-                      <img className="profile-photo-thumb pr-2" src={userIdToImageMap[option.value]} alt={option.label} />
-                    ) : (
-                      <Icon className="pr-2" I={MdPerson} />
-                    )}
                     {option.label}
                   </span>
                 </OverlayTrigger>
@@ -403,20 +425,14 @@ const Admin: React.FC = () => {
   if (!res.data) {
     return <p>Loading...</p>;
   }
-  const userIdToImageMap = {};
-  res.data.users.forEach((user) => {
-    if (user.imageUrl) {
-      userIdToImageMap[user.id] = user.imageUrl;
-    }
-  });
   const userOptions: ImpersonateVal[] = res.data.users.map((user) => ({
     label: `${user.displayName} (${user.username})`,
     value: user.id,
+    imageUrl: user.imageUrl,
   }));
   return (
     <ImpersonateUser
       userOptions={userOptions}
-      userIdToImageMap={userIdToImageMap}
     />
   );
 };
diff --git a/app/javascript/components/workflows/professor/courses/show.tsx b/app/javascript/components/workflows/professor/courses/show.tsx
index 8f54104f3..f32c05bc1 100644
--- a/app/javascript/components/workflows/professor/courses/show.tsx
+++ b/app/javascript/components/workflows/professor/courses/show.tsx
@@ -86,21 +86,13 @@ const ShowCourse: React.FC = () => {
   if (!res.data) {
     return <Container><p>Loading...</p></Container>;
   }
-  const userIdToImageMap = {};
-  const allUsers = res.data.course.students
-    .concat(res.data.course.staff)
-    .concat(res.data.course.professors);
-  allUsers.forEach((user) => {
-    if (user.imageUrl) {
-      userIdToImageMap[user.id] = user.imageUrl;
-    }
-  });
   const userOptions: GroupedOptionsType<ImpersonateVal> = [
     {
       label: 'Students',
       options: res.data.course.students.map((user) => ({
         label: `${user.displayName} (${user.username})`,
         value: user.id,
+        imageUrl: user.imageUrl,
       })),
     },
     {
@@ -108,6 +100,7 @@ const ShowCourse: React.FC = () => {
       options: res.data.course.staff.map((user) => ({
         label: `${user.displayName} (${user.username})`,
         value: user.id,
+        imageUrl: user.imageUrl,
       })),
     },
     {
@@ -115,6 +108,7 @@ const ShowCourse: React.FC = () => {
       options: res.data.course.professors.map((user) => ({
         label: `${user.displayName} (${user.username})`,
         value: user.id,
+        imageUrl: user.imageUrl,
       })),
     },
   ];
@@ -145,7 +139,6 @@ const ShowCourse: React.FC = () => {
         <DocumentTitle title={res.data.course.title}>
           <CourseExams courseExams={res.data.course.exams} />
           <ImpersonateUser
-            userIdToImageMap={userIdToImageMap}
             userOptions={userOptions}
             courseId={res.data.course.id}
           />