Renamed submit() to submitBook() to avoid HTML form conflicts

Author: HoussamLh

debugging/book-library/index.html

@@ -52,7 +52,7 @@ <h1>Library</h1>
           type="submit"
           value="Submit"
           class="btn btn-primary"
-          onclick="submit();">
+          onclick="submitBook(event);">
       </div>
     </div>
 

debugging/book-library/script.js

@@ -1,45 +1,45 @@
 let myLibrary = [];
 
-window.addEventListener("load", function (e) {
+window.addEventListener("load", function () {
   populateStorage();
-  //render();
 });
 
 function populateStorage() {
-  if (myLibrary.length == 0) {
-    let book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
-    let book2 = new Book("The Old Man and the Sea","Ernest Hemingway",127,true);
-    myLibrary.push(book1);
-    myLibrary.push(book2);
-    render();
+  if (myLibrary.length === 0) {
+    const book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
+    const book2 = new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true);
+    myLibrary.push(book1, book2);
   }
+  render();
 }
 
 const titleEl = document.getElementById("title");
 const authorEl = document.getElementById("author");
 const pagesEl = document.getElementById("pages");
 const checkEl = document.getElementById("check");
 
-//check the right input from forms and if its ok -> add the new book (object in array)
-//via Book function and start render function
-function submit() {
+// Add book from form
+function submitBook(event) {
+  event.preventDefault(); // Prevent page reload
+
   const titleVal = titleEl.value.trim();
   const authorVal = authorEl.value.trim();
   const pagesVal = Number(pagesEl.value);
-  if (
-    !titleVal ||
-    !pagesVal ||
-    !authorVal
-  ) {
+
+  if (!titleVal || !authorVal || !pagesVal) {
     alert("Please fill all fields!");
-    return false;
-  } else {
-    //fix: change title.value to author.value
-    let book = new Book(titleVal, authorVal, pagesVal, checkEl.checked);
-    //Fix: change library.push(book) to myLibrary.push(book).
-    myLibrary.push(book);
-    render();
+    return;
   }
+
+  const book = new Book(titleVal, authorVal, pagesVal, checkEl.checked);
+  myLibrary.push(book);
+  render();
+
+  // Clear form
+  titleEl.value = "";
+  authorEl.value = "";
+  pagesEl.value = "";
+  checkEl.checked = false;
 }
 
 function Book(title, author, pages, check) {
@@ -50,59 +50,39 @@ function Book(title, author, pages, check) {
 }
 
 function render() {
-  let table = document.getElementById("display");
-  let rowsNumber = table.rows.length;
-  //delete old table
-  // Fix : add a ) to the end of the for loop condition
-  // to avoid syntax error.
+  const table = document.getElementById("display");
   const tbody = table.querySelector("tbody");
-  tbody.innerHTML = "";
-  //insert updated row and cells
-  let length = myLibrary.length;
-  for (let i = 0; i < length; i++) {
-    let row = table.insertRow(1);
-    let titleCell = row.insertCell(0);
-    let authorCell = row.insertCell(1);
-    let pagesCell = row.insertCell(2);
-    let wasReadCell = row.insertCell(3);
-    let deleteCell = row.insertCell(4);
-    titleCell.innerText = myLibrary[i].title;
-    authorCell.innerText = myLibrary[i].author;
-    pagesCell.innerText = myLibrary[i].pages;
+  tbody.innerHTML = ""; // clear old rows
 
-    //add and wait for action for read/unread button
-    let readBtn = document.createElement("button");
-    readBtn.id = `readBtn-${i}`;
-    readBtn.className = "btn btn-success";
-    wasReadCell.appendChild(readBtn);
-    let readStatus = "";
-    // Fix: change myLibrary[i].check to myLibrary[i].check == true
-    // to check if the book is read or not.
-    if (myLibrary[i].check == true) {
-      readStatus = "Yes";
-    } else {
-      readStatus = "No";
-    }
-    readBtn.innerText = readStatus;
+  myLibrary.forEach((book, i) => {
+    const row = tbody.insertRow();
+    row.insertCell(0).textContent = book.title;
+    row.insertCell(1).textContent = book.author;
+    row.insertCell(2).textContent = book.pages;
 
-    readBtn.addEventListener("click", function () {
-      myLibrary[i].check = !myLibrary[i].check;
+    // Read/Unread button
+    const readCell = row.insertCell(3);
+    const readBtn = document.createElement("button");
+    readBtn.className = "btn btn-success";
+    readBtn.textContent = book.check ? "Yes" : "No";
+    readBtn.addEventListener("click", () => {
+      book.check = !book.check;
       render();
     });
+    readCell.appendChild(readBtn);
 
-    //add delete button to every row and render again
-    // Fix : 
-    // change delBut to delButton because we declare it.
-    // The event listener is "clicks" instead of "click".
-    let deleteBtn = document.createElement("button");
-    deleteBtn.id = `deleteBtn-${i}`;
-    deleteCell.appendChild(deleteBtn);
-    deleteBtn.className = "btn btn-warning";
-    deleteBtn.innerHTML = "Delete";
-    deleteBtn.addEventListener("click", function () {
-      alert(`You've deleted title: ${myLibrary[i].title}`);
-      myLibrary.splice(i, 1);
-      render();
+    // Delete button
+    const delCell = row.insertCell(4);
+    const delBtn = document.createElement("button");
+    delBtn.className = "btn btn-warning";
+    delBtn.textContent = "Delete";
+    delBtn.addEventListener("click", () => {
+      if (confirm(`Are you sure you want to delete "${book.title}"?`)) {
+        myLibrary.splice(i, 1);
+        render();
+      }
     });
-  }
+    delCell.appendChild(delBtn);
+  });
 }
+