Normalise monospace fonts #1652
Conversation
✅ Deploy Preview for cyf-tracks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-curriculum ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-common ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-sdc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-launch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-itd ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-piscine ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I have normalising the fonts to be the same, and removed the unused space grotesk. Viewing on linux, The main homepage module grids for SDC and ITP, for example, are now entirely monospaced, where before they were sans serif. Were these pages always monospaced on mac? @illicitonion I don't have a mac to test, do you? would you please be able to check the deploys above look the same? |
|
This was the front page on a mac before this change: 
And this is after: 
I think we probably don't want monospace all the things. FWIW the standard CYF font is Raleway (which you can hopefully see on https://programming.codeyourfuture.io/prs-needing-review/) - we should maybe just standardise on it everywhere we want a non-monospace font? |
|
@illicitonion Updated now so that:
|
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This generally LGTM!
I looked through a few sample sprints, and a few things struck me as slightly off:
- Learning objectives font is quite large (e.g. on https://deploy-preview-1652--cyf-sdc.netlify.app/tools/sprints/1/prep/ and in https://deploy-preview-1652--cyf-sdc.netlify.app/tools/sprints/1/day-plan/#terminal-skills-workshop and https://deploy-preview-1652--cyf-sdc.netlify.app/tools/sprints/1/success/)
- Multi-choice quiz answers are quite large (e.g. on https://deploy-preview-1652--cyf-sdc.netlify.app/tools/sprints/1/prep/#computer-quiz)
- Input placeholders are quite large (e.g. in the register on https://deploy-preview-1652--cyf-sdc.netlify.app/tools/sprints/1/day-plan/)
- The menu to go back (e.g. "Tools > Sprint 1" on https://deploy-preview-1652--cyf-sdc.netlify.app/tools/sprints/1/day-plan/#terminal-skills-workshop at the top) are now a bit small
Can we clean those few things up? Then let's merge!
|
That should be the main issue fixed. I have noticed a lot of other styling issues, like how the main page headings are different between SDC and ITP, but I will leave that for another time |
|
Those all look good now, but suddenly default block content has become serif for me? It looks like |
|
I had missed swapping out a |
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Perfect, thank you so much!
github-project-automation
bot
moved this from 🏗 In progress
to 👀 In review
in Curriculum Planning
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Curriculum Planning
A couple of styling issues are present on ubuntu, and likely other linux systems, because the font "Space Grotesk" is used:
Also, throughout the different CSS files, a range of different font stacks are used for monospace fonts
This normalises all the monospace fonts to use the same font stack.
Checklist