From 4f80cc0b8a1cbdb0062f4155c95cf50681485b20 Mon Sep 17 00:00:00 2001 From: Marius Cristea Date: Sat, 20 Jul 2019 11:26:41 +0300 Subject: [PATCH 1/4] fix: when service update cron returns an error, we should use the old data --- inc/admin.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inc/admin.php b/inc/admin.php index 456df54f..79352837 100755 --- a/inc/admin.php +++ b/inc/admin.php @@ -355,7 +355,7 @@ function daily_sync() { $request = new Optml_Api(); $data = $request->get_user_data( $api_key ); - if ( $data === false ) { + if ( $data === false || is_wp_error( $data ) ) { return; } From 13ce7588dfa1f6402b2ab4dcff898c3b8ec1097f Mon Sep 17 00:00:00 2001 From: Marius Cristea Date: Sun, 21 Jul 2019 22:36:23 +0300 Subject: [PATCH 2/4] fix: improve generic lazyload setting description and behaviour, fix #119 --- assets/vue/components/options.vue | 2 +- inc/admin.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/assets/vue/components/options.vue b/assets/vue/components/options.vue index aa199fa3..976f5007 100755 --- a/assets/vue/components/options.vue +++ b/assets/vue/components/options.vue @@ -20,7 +20,7 @@ :class="tab === 'resize' ? 'is-active' : ''" :title="all_strings.settings_resize_menu_item+' '+all_strings.settings_menu_item">{{all_strings.settings_resize_menu_item}} -
  • {{all_strings.lazyload_settings_menu_item}}
  • diff --git a/inc/admin.php b/inc/admin.php index 79352837..15ff4704 100755 --- a/inc/admin.php +++ b/inc/admin.php @@ -551,7 +551,7 @@ private function get_dashboard_strings() { 'enable_network_opt_title' => __( 'Enable network based optimizations', 'optimole-wp' ), 'enable_resize_smart_title' => __( 'Enable Smart Cropping', 'optimole-wp' ), 'enable_lazyload_placeholder_title' => __( 'Enable generic lazyload placeholder', 'optimole-wp' ), - 'enable_lazyload_placeholder_desc' => __( 'Optimole will use a generic lazyload placeholder instead of the low quality version of your image when doing the lazyload.', 'optimole-wp' ), + 'enable_lazyload_placeholder_desc' => __( 'Enabling this might affect the user experience in some cases, however it will reduce the number of total requests and page weight. Try it out and see how works best for you!', 'optimole-wp' ), 'show' => __( 'Show', 'optimole-wp' ), 'filter_operator_contains' => __( 'contains', 'optimole-wp' ), 'filter_operator_is' => __( 'is', 'optimole-wp' ), From 178d1fc29aa013862293291f9bbbe7480880cdd3 Mon Sep 17 00:00:00 2001 From: Marius Cristea Date: Sun, 21 Jul 2019 22:40:25 +0300 Subject: [PATCH 3/4] fix: clicking on advanced menu move the focus to the focus to the compression tab, fix #118 --- assets/vue/components/options.vue | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/assets/vue/components/options.vue b/assets/vue/components/options.vue index 976f5007..33aa307f 100755 --- a/assets/vue/components/options.vue +++ b/assets/vue/components/options.vue @@ -54,14 +54,14 @@