-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FAULT/remove FATAL exception severity #108
Conversation
This is now included in #99 |
This should be merged now instead of waiting for 0.10.0 no? |
a) it's breaking |
It never actually existed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed FATAL since it doesn't actually exist (not in LL v3 and when I was looking into it before, it also didn't exist in LL v2), this is good to go now. |
* Add FAULT exception severity * Remove FATAL It never actually existed in LL v3. Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
* Add FAULT exception severity * Remove FATAL It never actually existed in LL v3. Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
* Add FAULT exception severity * Remove FATAL It never actually existed in LL v3. Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Certain tracks can end up being a FAULT severity, which isn't in our enums.
Example tracks:
https://cdn.discordapp.com/attachments/169456266240983041/932099216166252574/721770.mp4
https://cdn.discordapp.com/attachments/692039523965861988/856151137483620402/WhatsApp_Video_2021-04-02_at_22.03.20_1.mp4
https://cdn.discordapp.com/attachments/583996272898342912/857341893432180766/yoga_time.mp4
Current response before PR:
The Track Error dialog box for the audio cog is never sent with this traceback occuring. After this PR it's sent properly.