Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAULT/remove FATAL exception severity #108

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Add FAULT/remove FATAL exception severity #108

merged 2 commits into from
Mar 15, 2022

Conversation

aikaterna
Copy link
Member

Certain tracks can end up being a FAULT severity, which isn't in our enums.

Example tracks:
https://cdn.discordapp.com/attachments/169456266240983041/932099216166252574/721770.mp4
https://cdn.discordapp.com/attachments/692039523965861988/856151137483620402/WhatsApp_Video_2021-04-02_at_22.03.20_1.mp4
https://cdn.discordapp.com/attachments/583996272898342912/857341893432180766/yoga_time.mp4

Current response before PR:

[2022-01-16 23:17:04] [CRITICAL] red.main: Caught unhandled exception in <Task finished name='Task-115252304' coro=<Node._handle_op() done, defined at /.../cat38/lib/python3.8/site-packages/lavalink/node.py:363> exception=ValueError("'FAULT' is not a valid ExceptionSeverity")>:
Task exception was never retrieved
Traceback (most recent call last):
  File "/.../cat38/lib/python3.8/site-packages/lavalink/node.py", line 370, in _handle_op
    self.event_handler(op, event, data)
  File "/.../cat38/lib/python3.8/site-packages/lavalink/lavalink.py", line 331, in dispatch
    args = _get_event_args(data, raw_data)
  File "/.../cat38/lib/python3.8/site-packages/lavalink/lavalink.py", line 203, in _get_event_args
    "severity": enums.ExceptionSeverity(exception_data["severity"]),
  File "/usr/lib/python3.8/enum.py", line 339, in __call__
    return cls.__new__(cls, value)
  File "/usr/lib/python3.8/enum.py", line 663, in __new__
    raise ve_exc
ValueError: 'FAULT' is not a valid ExceptionSeverity

The Track Error dialog box for the audio cog is never sent with this traceback occuring. After this PR it's sent properly.
Screen Shot 2022-01-17 at 10 57 03 AM

@Jackenmen Jackenmen added this to the 0.10.0 milestone Jan 19, 2022
@aikaterna
Copy link
Member Author

This is now included in #99

@aikaterna aikaterna closed this Feb 17, 2022
@Jackenmen Jackenmen removed this from the 0.10.0 milestone Mar 2, 2022
@aikaterna aikaterna reopened this Mar 10, 2022
@Jackenmen Jackenmen added this to the 0.10.0 milestone Mar 10, 2022
@Drapersniper
Copy link
Contributor

This should be merged now instead of waiting for 0.10.0 no?

@Jackenmen
Copy link
Member

a) it's breaking
b) as of now, there are no plans for another 0.9 release

It never actually existed.
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jackenmen Jackenmen self-assigned this Mar 15, 2022
@Jackenmen Jackenmen changed the title Add FAULT exception severity Add FAULT/remove FATAL exception severity Mar 15, 2022
@Jackenmen
Copy link
Member

I removed FATAL since it doesn't actually exist (not in LL v3 and when I was looking into it before, it also didn't exist in LL v2), this is good to go now.

@Jackenmen Jackenmen merged commit c1ab862 into Cog-Creators:develop Mar 15, 2022
Drapersniper pushed a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 16, 2022
* Add FAULT exception severity

* Remove FATAL

It never actually existed in LL v3.

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper pushed a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 17, 2022
* Add FAULT exception severity

* Remove FATAL

It never actually existed in LL v3.

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper pushed a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 20, 2022
* Add FAULT exception severity

* Remove FATAL

It never actually existed in LL v3.

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants