Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relation extraction #173
Relation extraction #173
Changes from 22 commits
b20e7c8
eec6c59
56220aa
7ad88f5
233ce36
85a7015
5003548
541b47d
c042b0d
87d0c0c
4f42696
018d811
f3d3f44
e5f354e
c69de67
031d256
2259a6b
1c469e9
423b4e1
8ae9abb
186416c
451e33f
8b36413
2fb8fc9
930dd11
24b2841
193ecb1
03111a7
7ab60f4
40875f3
810d1dc
11dcb32
72187f6
5f67a4c
cfc0e91
9f4b220
19afa81
8eb1665
6e86fa2
5cee8cf
223ac9a
ea7d68c
1ea9738
9f6609e
1782c0b
fb86869
df21543
92a5e08
87d1a9c
ced1627
7b69710
37fd212
f0eda2b
10269b9
b8a45b2
20203ac
f057139
197a27a
86fd509
79dc069
323c895
f1c56bf
a78ff86
f09ceb2
32574f2
c081c3e
e2e48b5
4ce5ba3
21c09ff
8123689
57ab0c5
9da5aa6
009e832
1a7d130
53dba6a
92613ed
a49a44a
6456e6e
5aac9ab
9c50b30
b071607
89d9128
e6e99cb
307d194
fb7efe3
c235daf
fcdf2e3
aad0a73
8a9026b
f94e349
0770356
bdf20f5
f7b5aaf
3e827cf
aaf6533
18f9bb8
503513c
040821b
ed7c8d5
8d0bfe4
3f3a780
3f56824
b7a4987
77d27b0
a9258a2
0ed70fb
8db2e76
6eea6b7
6972310
d03316c
8cb12a4
d10318a
12acaeb
4c14a3a
382cefc
35b0913
d48bc41
3068516
72643fc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To Zeljko's prior comment. This module should be similar to MetaCAT so, i.e. subclasses PipeRunner, so that pipe and call etc. are available. We want ultimately want API like:
CAT(cdb, meta_cats=[ MetaCAT .. ] , rel_cats=[ RelCAT(... ), ... ])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
partially done, probably need to add this to the pipe file as well now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this init method is only indented 3 spaces, can we consistently use 4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another style thing - can we add a space before the line continuation backslash, i.e. check medcat_ner.py l86:88, actually as this is a list they're not needed at all