-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CU-8692kpchc Fix for Rosalind link not working #342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mart-r
changed the title
CU-8692kpchc Temporary fix for Rosalind link not working
CU-8692kpchc ~~Temporary~~ fix for Rosalind link not working
Aug 29, 2023
mart-r
changed the title
CU-8692kpchc ~~Temporary~~ fix for Rosalind link not working
CU-8692kpchc Fix for Rosalind link not working
Aug 29, 2023
tomolopolis
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mart-r
added a commit
that referenced
this pull request
Sep 21, 2023
* remove bad merge <p> element * CU-8692kpchc Fix for Rosalind link not working (#342) * CU-8692kpchc Add the 403 exception to vocab downloader * CU-8692kpchc Add the new vocab download link * Add missing self argument (#343) To `_refset_df2dict ` method in Snomed preprocessing * CU-8692kn0yv Fix issue with fake dict in identifier based config More specifically the get method which was not able to return default values for non-existant keys (#341) * CU-8692mevx8 Fix issue with filters not taking effect in train_supervised method (#345) * CU-8692mevx8 Fix issue with filters not taking effect in train_supervised method * CU-8692mevx8 Fix filter retention in train_supervised method --------- Co-authored-by: tomolopolis <tsearle88@gmail.com>
mart-r
added a commit
that referenced
this pull request
Sep 22, 2023
* CU-8692kpchc Add the 403 exception to vocab downloader * CU-8692kpchc Add the new vocab download link
mart-r
added a commit
that referenced
this pull request
Sep 22, 2023
* CU-8692kpchc Add the 403 exception to vocab downloader * CU-8692kpchc Add the new vocab download link
mart-r
added a commit
that referenced
this pull request
Oct 12, 2023
* CU-8692kpchc Add the 403 exception to vocab downloader * CU-8692kpchc Add the new vocab download link
mart-r
added a commit
that referenced
this pull request
Oct 13, 2023
* CU-8692kpchc Add the 403 exception to vocab downloader * CU-8692kpchc Add the new vocab download link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the 403 exception to vocab downloader
This is a temporary fix until we get the vocab up on AWS (or somewhere else) for a more permanent solution.But at least GHA should pass now.I've now updated the PR with a new, permanent link for the vocab.