CU-2exy49p: Make sure the cdb.add_concept really adds a concept or somehow make it clear #370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per clickup.
Make sure the
cdb.add_concept
really adds a concept or somehow make it clearFunction is a bit confusing as it in fact requires the names to be pre-processed before it can be used.
Changed cdb.add_concept to a protected method, and changed all calls to it within MedCAT as appropriate.
I've also added a line of doucmentation pointing to to the helper function
medcat.preprocessing.cleaners.prepare_name
.add_concept
cannot be made private currently due to it useage. Converselyprepare_name
cannot be used in the method as thecdbmaker.config
is not accessible.It might be worth checking with users that they're not using
add_concept
before this is merged.