Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-86949yar7: Add logged warning for when multiprocessing fails due to being out of memory #415

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

mart-r
Copy link
Collaborator

@mart-r mart-r commented Apr 12, 2024

The underlying issue manifested in the following way:

When calling multiprocessing_batch_char_size the output would come out completely empty. Nothing logged as to what happened or why.

This is because the machine in question has 128GB of RAM and the default minimum expected RAM is 10%. And the machine happened to have around 6GB of free memory. Which is less than 5% (and less than the minimum required).
The solution for the user is to specify a smaller min_free_memory value when calling the method (e.g 0.005 in this case for around 500MB).

So what this PR does:

  • Adds logged warning for when this happens along with suggestion for a fix
  • Adds and uses new argument min_free_memory_size where users can specify a human-readable minimum memory amount

This way, in future cases, we'll know what the issue is and how to fix it.

@tomolopolis
Copy link
Member

Copy link
Member

@tomolopolis tomolopolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mart-r mart-r merged commit 8c107d6 into master Apr 17, 2024
5 checks passed
@mart-r mart-r deleted the CU-86949yar7-multiprocessing-failures branch August 12, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants