CU-8694py1jr fix old config load with reg json #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mart-r
changed the title
|
all looks good, tested on the metacat models from KCH, works fine now! |
tomolopolis
reviewed
Jun 3, 2024
| @@ -15,9 +15,24 @@ def weighted_average_function(self) -> Callable[[float], int]: | |||
|
|
|||
|
|
|||
| def is_old_type_config_dict(d: dict) -> bool: | |||
There was a problem hiding this comment.
This assumes all configs were created post the pydantic changes to the config right?
There was a problem hiding this comment.
Yes, that would be true since before that it would have been saved as a raw dict.
tomolopolis
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last PR for (almost) primitive config (#425) had a few issues:
ConfigMetaCAT)This PR fixes the above.
It also adds tests for old types of config (regular, MetaCAT, TNER, and RelCAT).
For each, it makes sure that they're classified as old style, and that a value changed within them is correctly identified as having been changed / loaded off disk.