-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deid logging update #466
Deid logging update #466
Conversation
Pushing change to document chunking and add logging for it as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use lazy evaluation in logging unless there's an explicit reason not to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Maybe the only left over comment:
Is this all the logging DeID needs? Perhaps there's need for more logging somewhere? If so, would be great to address it all at once. If this is all we need, then great!
I feel we've covered all of it. |
fine without further debug statements. Adding debug elsewhere you see fit is up to you, but the Trainer callback also has the same purpose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This minor update is to document chunking (better) and add logging for it as well