Skip to content

Commit

Permalink
Revert "prevent double-dispatch of uno events bound to function keys"
Browse files Browse the repository at this point in the history
and its follow up fix for ctrl+s. Which is a bit of a bodge.
So revert the two together and have another round at this later.

The goal was to enable "F3" to do something which isn't needed yet.

This reverts commit b2b637e.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I79869dc3e07c86edf9f99bb6100b9e6dcb5b5698
  • Loading branch information
caolanm committed Nov 22, 2024
1 parent b872229 commit 0620661
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions browser/src/map/handler/Map.Keyboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -400,11 +400,6 @@ L.Map.Keyboard = L.Handler.extend({
if (this._map.uiManager.isUIBlocked())
return;

// if we press F1/F2 then the keyboard event is handled twice, use that
// the defaultPrevented is set the first time to avoid the double dispatch
if (ev.defaultPrevented && ev.keyCode !== this.keyCodes.S)
return;

if (window.KeyboardShortcuts.processEvent(app.UI.language.fromURL, ev)) {
ev.preventDefault();
return;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ describe(['tagdesktop', 'tagnextcloud', 'tagproxy'], 'PDF View Tests', function(
});

it('PDF page down', { env: { 'pdf-view': true } }, function() {
cy.cGet('#map').type('{pagedown}');
cy.cGet('#map').type('{pagedown}');
cy.cGet('#preview-frame-part-1').should('have.attr', 'style', 'border: 2px solid darkgrey;');
cy.cGet('#map').type('{pageup}');
Expand Down

0 comments on commit 0620661

Please sign in to comment.