Add (external) connections stats to #NetVisualisation graph #10456
+165
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgothel
force-pushed
the
private/sgothel/analytics_connections
branch
from
310d919
to
6e99cc7
Compare
sgothel
changed the title
sgothel
force-pushed
the
private/sgothel/analytics_connections
branch
from
6e99cc7
to
33328ac
Compare
|
Note: The margin to accompany the new right-hand y-axis required some fiddling as I haven't seen utilization of rendered text width (w/ font em size). However, I tested the right margin from like zero to 100% of net::Defaults.maxExtConnections in regards to the tick-label by simply hacking the maximum. |
caolanm
force-pushed
the
private/sgothel/analytics_connections
branch
from
33328ac
to
a90b076
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sgothel
force-pushed
the
private/sgothel/analytics_connections
branch
from
a90b076
to
6fc2bb3
Compare
This was referenced Nov 11, 2024
caolanm
reviewed
Nov 13, 2024
|
I think here we only need the last patch in this pr, as it seems to build without it and doesn't depend on the others? |
sgothel
force-pushed
the
private/sgothel/analytics_connections
branch
from
6fc2bb3
to
4d6f5ee
Compare
6 tasks
sgothel
force-pushed
the
private/sgothel/analytics_connections
branch
2 times, most recently
from
60f900a
to
db13f7d
Compare
sgothel
force-pushed
the
private/sgothel/analytics_connections
branch
from
db13f7d
to
cc5a92b
Compare
…ation graph Have AdminModel accumulate StreamSocket::getExternalConnectionCount() statistics in same size and interval as net recv/sent. The added statistic is rendered into the #NetVisualisation graph using a second y-axis on the right. Here we use a human-readable quantity tick with added multiple, percentage (1/100) or permyriad (1/10'000) to net::Defaults.maxExtConnections. Graph is accessible via `/browser/dist/admin/adminAnalytics.html#networkview`. Signed-off-by: Sven Göthel <sven.gothel@collabora.com> Change-Id: I614801e7901a23847ea35a2021ecc53a1c000110
sgothel
force-pushed
the
private/sgothel/analytics_connections
branch
from
cc5a92b
to
390eb76
Compare
|
untangled from #10455 |
mmeeks
approved these changes
Nov 14, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Have AdminModel accumulate StreamSocket::getExternalConnectionCount() statistics
in same size and interval as net recv/sent.
The added statistic is rendered into the #NetVisualisation graph using a second y-axis on the right.
Here we use a human-readable quantity tick with added multiple, percentage (1/100) or permyriad (1/10'000) to net::Defaults.maxExtConnections.
Graph is accessible via
/browser/dist/admin/adminAnalytics.html#networkview.Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay