Improve impress templates #10463
Open
Improve impress templates #10463
+269
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rash419
force-pushed
the
improve-impress-templates
branch
2 times, most recently
from
74f6d0a
to
3343b39
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Rash419
force-pushed
the
improve-impress-templates
branch
3 times, most recently
from
21de956
to
bb3c770
Compare
Rash419
commented
Nov 22, 2024
| @@ -3311,6 +3315,34 @@ void lokit_main( | |||
| return false; | |||
| } | |||
|
|
|||
| // copy default tempates from 'common' dir to shared templates dir | |||
| // TODO: maybe I shouldn't copy if whole point to mounting is that we don't require copying. | |||
There was a problem hiding this comment.
I am not sure, how can we improve here except of copying default templates ?
Rash419
commented
Nov 22, 2024
| if (!JailUtil::bind(sharedTemplate, loJailDestImpressTemplatePath) || | ||
| !JailUtil::remountReadonly(sharedTemplate, loJailDestImpressTemplatePath)) | ||
| { | ||
| // TODO: actually do this link on failure |
There was a problem hiding this comment.
If I disable the mounting default templates templates doesn't show up at all. 1st we need to fix default template loading issue I think
…on/template/presnt - once we can download the templates from remote server it can be access by lokit and gets added to MasterSlides impress Signed-off-by: Rashesh <rashesh.padia@collabora.com> Change-Id: I55cb4f340f66d353594331e25debd7124f25f042
- this remote poll can download both fonts and tempalates. It also can be extended to download more asset from remote server if needed in future Signed-off-by: Rashesh <rashesh.padia@collabora.com> Change-Id: I4418319d0e1f9f3081b9dd1443719cab8ad6bbfc
Signed-off-by: Rashesh <rashesh.padia@collabora.com> Change-Id: Idc82abd26f06549b6666bfeab1fb3967cec2d303
…igPoll` Signed-off-by: Rashesh <rashesh.padia@collabora.com> Change-Id: I707486cb4f340058ba98e2cb574a81ec8317eabf
… as well - use `remote_asset_config.url` when both `remote_asset_config.url` and `remote_font_config.url` is defined. Signed-off-by: Rashesh <rashesh.padia@collabora.com> Change-Id: I3b80fea6324b4e378c4edd0ee71fd2dc7764ea14
- it was replaced by `RemoteAssetConfigPoll` Signed-off-by: Rashesh <rashesh.padia@collabora.com> Change-Id: I06490d037c9da3a90495d367c1c99a0a5aa8121c
Rash419
force-pushed
the
improve-impress-templates
branch
from
bb3c770
to
42f6475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay